Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor table schemas to catalog entry #2900

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Refactor table schemas to catalog entry #2900

merged 1 commit into from
Feb 16, 2024

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Feb 16, 2024

This is the first set of PR to change our catalog to use the catalogEntry based design.
This PR introduces the catalogEntry class and refactors the tableSchema to use the catalogEntry.
Tables names are case-insensitive now meaning that person and PeRson are the same table in kuzu.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (abf48f5) 93.43% compared to head (53685d3) 93.44%.

Files Patch % Lines
.../catalog/catalog_entry/rel_group_catalog_entry.cpp 77.27% 5 Missing ⚠️
.../catalog/catalog_entry/rel_table_catalog_entry.cpp 93.33% 4 Missing ⚠️
src/catalog/catalog_entry/table_catalog_entry.cpp 93.54% 4 Missing ⚠️
src/storage/wal_replayer.cpp 66.66% 4 Missing ⚠️
src/binder/bind/bind_ddl.cpp 95.12% 2 Missing ⚠️
src/catalog/catalog_set.cpp 94.28% 2 Missing ⚠️
...e/catalog/catalog_entry/node_table_catalog_entry.h 66.66% 2 Missing ⚠️
...de/catalog/catalog_entry/rel_group_catalog_entry.h 50.00% 2 Missing ⚠️
src/catalog/catalog_content.cpp 98.46% 1 Missing ⚠️
src/catalog/catalog_entry/catalog_entry.cpp 92.85% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2900   +/-   ##
=======================================
  Coverage   93.43%   93.44%           
=======================================
  Files        1100     1104    +4     
  Lines       42387    42466   +79     
=======================================
+ Hits        39606    39683   +77     
- Misses       2781     2783    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/include/common/types/case_insensitive_map.h Outdated Show resolved Hide resolved
src/binder/binder.cpp Show resolved Hide resolved
src/catalog/catalog.cpp Outdated Show resolved Hide resolved
src/catalog/catalog.cpp Outdated Show resolved Hide resolved
src/catalog/catalog.cpp Show resolved Hide resolved
src/include/catalog/catalog_content.h Show resolved Hide resolved
src/include/function/table_functions/call_functions.h Outdated Show resolved Hide resolved
src/processor/operator/aggregate/aggregate_hash_table.cpp Outdated Show resolved Hide resolved
src/storage/wal_replayer.cpp Outdated Show resolved Hide resolved
tools/shell/embedded_shell.cpp Show resolved Hide resolved
@acquamarin acquamarin merged commit 0d57b0b into master Feb 16, 2024
15 checks passed
@acquamarin acquamarin deleted the catalog-entry branch February 16, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants