-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for exporting database to parquet files #2897
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2897 +/- ##
==========================================
+ Coverage 93.45% 93.46% +0.01%
==========================================
Files 1104 1104
Lines 42468 42498 +30
==========================================
+ Hits 39687 39720 +33
+ Misses 2781 2778 -3 ☔ View full report in Codecov by Sentry. |
src/include/parser/port_db.h
Outdated
|
||
private: | ||
parsing_option_t parsingOptions; | ||
std::string filePath; | ||
common::FileType fileType; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just keep a readerConfig in this class. If so let's rename it to BoundFileInfo
9d57769
to
b1b6f99
Compare
slove comments fix
8f9082b
to
cc95076
Compare
No description provided.