add support for multiple query statements #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
andyfengHKU
reviewed
Feb 17, 2024
hououou
force-pushed
the
multiple_queries
branch
from
1ea057d
to
5f13e24
Compare
andyfengHKU
requested changes
Feb 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2889 +/- ##
==========================================
+ Coverage 93.48% 93.51% +0.03%
==========================================
Files 1116 1121 +5
Lines 42662 42913 +251
==========================================
+ Hits 39883 40131 +248
- Misses 2779 2782 +3 ☔ View full report in Codecov by Sentry. |
andyfengHKU
approved these changes
Feb 24, 2024
hououou
force-pushed
the
multiple_queries
branch
from
8f78154
to
373fb2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add support for multiple query statements.
Currently, we split multiple query statements into several query statements. Each query statement then triggers an auto transaction. This is because we do not support DDL in manual transactions. We should support multiple query statements in one transaction after we support DDL in manual transactions.