Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unique_ptr of LogicalType in Column and ColumnChunk #2864

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Feb 12, 2024

No description provided.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (c0be7f0) 93.41% compared to head (d2d7273) 93.41%.

Files Patch % Lines
...rc/processor/operator/persistent/index_builder.cpp 50.00% 1 Missing ⚠️
src/storage/store/column.cpp 95.65% 1 Missing ⚠️
src/storage/store/dictionary_chunk.cpp 50.00% 1 Missing ⚠️
src/storage/store/node_group.cpp 83.33% 1 Missing ⚠️
src/storage/store/struct_column.cpp 85.71% 1 Missing ⚠️
src/storage/store/struct_column_chunk.cpp 83.33% 1 Missing ⚠️
src/storage/store/var_list_column.cpp 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2864      +/-   ##
==========================================
- Coverage   93.41%   93.41%   -0.01%     
==========================================
  Files        1089     1089              
  Lines       42091    42095       +4     
==========================================
  Hits        39321    39321              
- Misses       2770     2774       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit 69f66f5 into master Feb 14, 2024
15 checks passed
@ray6080 ray6080 deleted the clean-up-logical-type branch February 14, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants