NULL is NULL Fix #2859
Merged
NULL is NULL Fix #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2859 +/- ##
==========================================
- Coverage 93.45% 93.44% -0.01%
==========================================
Files 1104 1104
Lines 42468 42470 +2
==========================================
- Hits 39687 39685 -2
- Misses 2781 2785 +4 ☔ View full report in Codecov by Sentry. |
andyfengHKU
requested changes
Feb 11, 2024
| @@ -12,7 +13,16 @@ std::shared_ptr<Expression> ExpressionBinder::bindNullOperatorExpression( | |||
| const ParsedExpression& parsedExpression) { | |||
| expression_vector children; | |||
| for (auto i = 0u; i < parsedExpression.getNumChildren(); ++i) { | |||
| children.push_back(bindExpression(*parsedExpression.getChild(i))); | |||
| if (parsedExpression.getChild(i)->getExpressionType() == common::ExpressionType::LITERAL) { | |||
There was a problem hiding this comment.
We probably can reuse existing code path to resolve ANY data type for NULL literals
auto boundChild = bindExpression(*parsedExpression.getChild(i));
// if boundChild.dataType == ANY
// implicitCastIfNecessary
There was a problem hiding this comment.
I've applied the requested change in the new force push
There was a problem hiding this comment.
I end up making a minor change to refactor the code.
andyfengHKU
force-pushed
the
nullisnull
branch
from
5a82aab
to
1255c52
Compare
andyfengHKU
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exact same PR as 2830, this time from a branch instead of a fork so as to pass CI tests.