Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MD5 Hashing to Test Framework #2642

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Add MD5 Hashing to Test Framework #2642

merged 1 commit into from
Jan 10, 2024

Conversation

mxwli
Copy link
Collaborator

@mxwli mxwli commented Jan 9, 2024

This is to allow for the incorporation of a CypherLogicTest into the framework.

@ray6080 ray6080 self-requested a review January 9, 2024 15:52
ray6080
ray6080 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good! Thanks!
Let's update the documentation on the testing framework.

Can you also open an issue that we can support md5 utility function with what you have under common?

test/include/test_runner/test_group.h Outdated Show resolved Hide resolved
test/include/test_runner/test_group.h Outdated Show resolved Hide resolved
src/include/common/md5.h Outdated Show resolved Hide resolved
test/test_files/md5testing/all_shortest_path_md5.test Outdated Show resolved Hide resolved
test/test_files/md5testing/order_by_md5.test Outdated Show resolved Hide resolved
test/test_runner/test_runner.cpp Outdated Show resolved Hide resolved
test/test_files/md5testing/md5.test Outdated Show resolved Hide resolved
@mxwli mxwli mentioned this pull request Jan 9, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2024 •
edited

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (7e4e0ea) 93.37% compared to head (071042f) 93.40%.
Report is 12 commits behind head on master.

Files Patch % Lines
src/common/md5.cpp 93.23% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2642      +/-   ##
==========================================
+ Coverage   93.37%   93.40%   +0.03%     
==========================================
  Files        1063     1066       +3     
  Lines       39403    39679     +276     
==========================================
+ Hits        36794    37064     +270     
- Misses       2609     2615       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxwli
added md5 hashing support for tests
071042f 
largely reformatted MD5 code.

added tests for MD5 hashing

added requested changes

fixed formatting associated with MD5 files

fixed formatting associated with MD5 files

added clang requirement

clang-format check for test_runner and test_parser

changed pointer to const in DigestToBase16

fixed compiler oversight
@mxwli mxwli merged commit 53025e3 into kuzudb:master Jan 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray6080 ray6080 ray6080 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mxwli @ray6080