Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension install #2634

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Extension install #2634

merged 1 commit into from
Jan 7, 2024

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Jan 5, 2024

This PR allows the user to install an extension remotely from our extension repository.
Currently, only httpfs is supported installing from remote repository. The extension will be downloaded to the data directory, and can be loaded by load extensino [name] after.

@acquamarin acquamarin changed the title Ext install Extension install Jan 5, 2024
@acquamarin acquamarin marked this pull request as draft January 5, 2024 23:12
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (6c85123) 93.21% compared to head (3646b4c) 93.37%.

Files Patch % Lines
src/extension/extension.cpp 78.26% 5 Missing ⚠️
src/include/binder/bound_extension_statement.h 83.33% 1 Missing ⚠️
src/include/planner/operator/logical_extension.h 75.00% 1 Missing ⚠️
src/include/processor/operator/install_extension.h 87.50% 1 Missing ⚠️
src/parser/transform/transform_extension.cpp 87.50% 1 Missing ⚠️
src/processor/map/map_extension.cpp 90.00% 1 Missing ⚠️
src/processor/operator/install_extension.cpp 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2634      +/-   ##
==========================================
+ Coverage   93.21%   93.37%   +0.16%     
==========================================
  Files        1060     1063       +3     
  Lines       39342    39403      +61     
==========================================
+ Hits        36672    36794     +122     
+ Misses       2670     2609      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acquamarin acquamarin marked this pull request as ready for review January 5, 2024 23:36
CMakeLists.txt Show resolved Hide resolved
src/include/processor/operator/install_extension.h Outdated Show resolved Hide resolved
src/processor/operator/install_extension.cpp Show resolved Hide resolved
@acquamarin acquamarin merged commit ff27203 into master Jan 7, 2024
14 checks passed
@acquamarin acquamarin deleted the ext-install branch January 7, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants