Rdf test fix #2629
Merged
Rdf test fix #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riolku
approved these changes
Jan 3, 2024
| @@ -20,7 +20,7 @@ using StringBuffer = common::StaticVector<std::pair<std::string, common::offset_ | |||
|
|
|||
| class IndexBuilderGlobalQueues { | |||
| public: | |||
| explicit IndexBuilderGlobalQueues(std::unique_ptr<storage::PrimaryKeyIndexBuilder> pkIndex); | |||
| explicit IndexBuilderGlobalQueues(storage::PrimaryKeyIndexBuilder* pkIndex); | |||
There was a problem hiding this comment.
Curious, why can't the global queues have ownership of the index anymore? We have to be careful that accesses to the index in any other fashion are properly synchronized, right?
There was a problem hiding this comment.
Because RDF copy requires CopyNode and CopyRel in a single physical plan. And CopyRel needs to access PrimaryKeyIndexBuilder before it being flushed to disk. It's easier to access if the ownership is in CopyNode instead of GlobalQueue
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2629 +/- ##
==========================================
+ Coverage 91.11% 93.21% +2.09%
==========================================
Files 1058 1058
Lines 39235 39234 -1
==========================================
+ Hits 35750 36571 +821
+ Misses 3485 2663 -822 ☔ View full report in Codecov by Sentry. |
andyfengHKU
force-pushed
the
rdf-test-fix
branch
from
6a22348
to
838c1a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initGlobalStateand stored in shared state. Responsible forIndexBuilderSharedStateinitLocalStateand stored in operator. Responsible for