Fix copy-to with header #2628
Merged
Fix copy-to with header #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acquamarin
force-pushed
the
demo-db-test
branch
from
b7dd380
to
8892cb5
Compare
acquamarin
force-pushed
the
demo-db-test
branch
from
8892cb5
to
2dc9edd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2628 +/- ##
==========================================
- Coverage 93.40% 91.32% -2.09%
==========================================
Files 1041 1046 +5
Lines 39002 39143 +141
==========================================
- Hits 36431 35747 -684
- Misses 2571 3396 +825 ☔ View full report in Codecov by Sentry. |
andyfengHKU
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the copy-to csv with header bug.
We used to serialize the header to the csv file in the localState, however this doesn't guarantee that the header will always be flushed as the first line in the csv file.
This PR moves the flushing of header to the sharedState, which guarantees that the header always be flushed first.