Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table schema refactor #2627

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Table schema refactor #2627

merged 1 commit into from
Jan 3, 2024

Conversation

andyfengHKU
Copy link
Contributor

  • Change std::vector<std::unique_ptr<Property>> properties; to std::vector<Property> properties;
  • Introduce PropertyInfo to replace Property while binding DDL statements. The rationale is we don't need tableID or propertyID at binding stage when generating DDLs.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (226b441) 91.31% compared to head (98bf039) 91.32%.

❗ Current head 98bf039 differs from pull request most recent head 0fea38c. Consider uploading reports for the commit 0fea38c to get more accurate results

Files Patch % Lines
src/binder/bind/ddl/bind_create_rdf_graph.cpp 0.00% 5 Missing ⚠️
src/include/catalog/node_table_schema.h 83.33% 1 Missing ⚠️
src/include/catalog/rdf_graph_schema.h 0.00% 1 Missing ⚠️
src/include/common/copy_constructors.h 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2627   +/-   ##
=======================================
  Coverage   91.31%   91.32%           
=======================================
  Files        1046     1046           
  Lines       39181    39145   -36     
=======================================
- Hits        35779    35748   -31     
+ Misses       3402     3397    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU merged commit d276d36 into master Jan 3, 2024
12 checks passed
@andyfengHKU andyfengHKU deleted the table-schema-refactor branch January 3, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants