Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary smart pointer in binder #2624

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (c471abe) 93.26% compared to head (b137caa) 93.39%.

Files Patch % Lines
src/catalog/catalog_content.cpp 94.44% 1 Missing ⚠️
src/include/binder/bound_comment_on.h 0.00% 1 Missing ⚠️
src/include/binder/bound_statement_visitor.h 90.00% 1 Missing ⚠️
src/include/binder/ddl/bound_drop_table.h 0.00% 1 Missing ⚠️
...ator/persistent/reader/csv/parallel_csv_reader.cpp 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2624      +/-   ##
==========================================
+ Coverage   93.26%   93.39%   +0.13%     
==========================================
  Files        1041     1041              
  Lines       39033    39002      -31     
==========================================
+ Hits        36405    36427      +22     
+ Misses       2628     2575      -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU force-pushed the remove-unnecessary-smart-pointer-binder branch from 1db8ed8 to b137caa Compare January 2, 2024 08:20
@andyfengHKU andyfengHKU merged commit 508dc50 into master Jan 2, 2024
14 checks passed
@andyfengHKU andyfengHKU deleted the remove-unnecessary-smart-pointer-binder branch January 2, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants