Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataType uuid #2623

Merged
merged 1 commit into from
Jan 4, 2024
Merged

DataType uuid #2623

merged 1 commit into from
Jan 4, 2024

Conversation

hououou
Copy link
Collaborator

@hououou hououou commented Jan 2, 2024 •
edited
Loading

I have read and agree to the terms under CLA.md.

This pr is the first version of the datatype uuid and it is based on DuckDB's implementation duckdb/duckdb#2343

TODO list:

  • [✅ ] rust API
  • [✅ ] c API
  • [✅] Java API
  • [✅ ] add function: gen_random_uuid()

@hououou hououou marked this pull request as draft January 2, 2024 02:57
@codecov Codecov
Copy link

codecov bot commented Jan 2, 2024 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (838c1a4) 93.21% compared to head (752856f) 93.21%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/common/types/uuid.cpp 91.66% 4 Missing ⚠️
src/function/vector_cast_functions.cpp 90.00% 1 Missing ⚠️
tools/nodejs_api/src_cpp/node_util.cpp 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #2623    +/-   ##
========================================
  Coverage   93.21%   93.21%            
========================================
  Files        1058     1060     +2     
  Lines       39234    39342   +108     
========================================
+ Hits        36571    36673   +102     
- Misses       2663     2669     +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hououou hououou marked this pull request as ready for review January 2, 2024 20:13
acquamarin
acquamarin reviewed Jan 2, 2024
View reviewed changes
src/common/type_utils.cpp Show resolved Hide resolved
src/common/types/uuid.cpp Outdated Show resolved Hide resolved
src/common/types/uuid.cpp Outdated Show resolved Hide resolved
src/common/types/uuid.cpp Outdated Show resolved Hide resolved
src/common/types/uuid.cpp Outdated Show resolved Hide resolved
src/include/common/types/uuid.h Outdated Show resolved Hide resolved
tools/java_api/src/main/java/com/kuzudb/KuzuDataTypeID.java Outdated Show resolved Hide resolved
tools/python_api/src_py/types.py Show resolved Hide resolved
test/test_files/tinysnb/uuid/csv.test Outdated Show resolved Hide resolved
test/test_files/tinysnb/uuid/simpleTest.test Outdated Show resolved Hide resolved
acquamarin
acquamarin reviewed Jan 3, 2024
View reviewed changes
dataset/tinysnb/vPerson.csv Show resolved Hide resolved
src/common/types/uuid.cpp Outdated Show resolved Hide resolved
test/test_files/tinysnb/uuid/simpleTest.test Outdated Show resolved Hide resolved
@mewim
Copy link
Member

mewim commented Jan 4, 2024

Python API change LGTM

@hououou hououou force-pushed the uuid branch 2 times, most recently from 53648e3 to d02f374 Compare January 4, 2024 15:42
@hououou
initial version of uuid
752856f 
pytest & rusttest ignore
@hououou hououou merged commit 6c85123 into master Jan 4, 2024
14 checks passed
@hououou hououou deleted the uuid branch January 4, 2024 18:44
This was referenced Feb 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mewim mewim mewim left review comments

@acquamarin acquamarin acquamarin approved these changes

@ray6080 ray6080 Awaiting requested review from ray6080

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hououou @mewim @acquamarin