Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear unnecessary smart ptr parser #2622

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

@andyfengHKU andyfengHKU force-pushed the clear-unnecessary-smart-ptr-parser branch from dd89f0d to a607e32 Compare January 1, 2024 09:06
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (164a55c) 93.28% compared to head (278aaef) 93.27%.

Files Patch % Lines
...include/parser/expression/parsed_case_expression.h 85.71% 1 Missing ⚠️
src/include/parser/expression/parsed_expression.h 0.00% 1 Missing ⚠️
...de/parser/expression/parsed_parameter_expression.h 0.00% 1 Missing ⚠️
...ude/parser/expression/parsed_subquery_expression.h 50.00% 1 Missing ⚠️
...parser/query/reading_clause/in_query_call_clause.h 0.00% 1 Missing ⚠️
...nclude/parser/query/updating_clause/merge_clause.h 0.00% 1 Missing ⚠️
.../include/parser/query/updating_clause/set_clause.h 50.00% 1 Missing ⚠️
src/parser/transform/transform_graph_pattern.cpp 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2622      +/-   ##
==========================================
- Coverage   93.28%   93.27%   -0.01%     
==========================================
  Files        1037     1036       -1     
  Lines       38870    38870              
==========================================
- Hits        36259    36257       -2     
- Misses       2611     2613       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU force-pushed the clear-unnecessary-smart-ptr-parser branch 2 times, most recently from d1ca191 to c6ee455 Compare January 1, 2024 09:37
@andyfengHKU andyfengHKU force-pushed the clear-unnecessary-smart-ptr-parser branch from c6ee455 to 278aaef Compare January 1, 2024 09:48
@andyfengHKU andyfengHKU merged commit 9446b7b into master Jan 1, 2024
14 checks passed
@andyfengHKU andyfengHKU deleted the clear-unnecessary-smart-ptr-parser branch January 1, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants