Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Httpfs #2616

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Httpfs #2616

merged 1 commit into from
Jan 4, 2024

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Dec 23, 2023

This PR implements the extension framework and adds the load extension [path] statement to allow the user to load an extension in kuzu.
Currently, extensions are not supported on windows platform due to a linking error.

@acquamarin acquamarin marked this pull request as draft December 23, 2023 22:13
Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ray6080 should check the change related to fileSystems

Makefile Outdated Show resolved Hide resolved
scripts/antlr4/Cypher.g4.copy Outdated Show resolved Hide resolved
src/include/common/file_system/file_system.h Outdated Show resolved Hide resolved
src/include/processor/execution_context.h Show resolved Hide resolved
src/processor/map/map_load.cpp Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
extension/httpfs/CMakeLists.txt Outdated Show resolved Hide resolved
extension/httpfs/include/httpfs.h Outdated Show resolved Hide resolved
third_party/httplib/httplib.h Outdated Show resolved Hide resolved
src/processor/map/map_load.cpp Outdated Show resolved Hide resolved
src/include/common/system_message.h Outdated Show resolved Hide resolved
extension/httpfs/test/CMakeLists.txt Outdated Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
#else
auto libHdl = dlopen(path.c_str(), RTLD_NOW | RTLD_LOCAL);
#endif
if (libHdl == nullptr) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests for these exceptions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message is system dependent, we should improve our testing framework so that it allows fuzzy match error strings.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Can you open an issue on this? We should improve the testing framework for this.

extension/httpfs/test/test_files/http.test Show resolved Hide resolved
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 90 lines in your changes are missing coverage. Please review.

Comparison is base (1d1779f) 91.32% compared to head (f999fa3) 91.11%.

Files Patch % Lines
src/processor/operator/load_extension.cpp 0.00% 14 Missing ⚠️
src/include/processor/operator/load_extension.h 0.00% 11 Missing ⚠️
.../include/planner/operator/logical_load_extension.h 0.00% 8 Missing ⚠️
src/common/file_system/file_system.cpp 40.00% 6 Missing ⚠️
src/common/file_system/virtual_file_system.cpp 16.66% 5 Missing ⚠️
...rc/include/binder/bound_load_extension_statement.h 0.00% 5 Missing ⚠️
src/planner/plan/plan_load_extension.cpp 0.00% 4 Missing ⚠️
src/processor/map/map_load_extension.cpp 0.00% 4 Missing ⚠️
src/binder/bind/bind_load_extension.cpp 0.00% 3 Missing ⚠️
src/binder/binder.cpp 0.00% 3 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2616      +/-   ##
==========================================
- Coverage   91.32%   91.11%   -0.21%     
==========================================
  Files        1046     1058      +12     
  Lines       39143    39235      +92     
==========================================
+ Hits        35747    35749       +2     
- Misses       3396     3486      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acquamarin acquamarin force-pushed the httpfs branch 3 times, most recently from 6fabe51 to 886f584 Compare January 4, 2024 00:43
@acquamarin acquamarin marked this pull request as ready for review January 4, 2024 01:14
@acquamarin acquamarin merged commit 92350a2 into master Jan 4, 2024
13 of 14 checks passed
@acquamarin acquamarin deleted the httpfs branch January 4, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants