-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Httpfs #2616
Httpfs #2616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ray6080 should check the change related to fileSystems
src/processor/operator/load.cpp
Outdated
#else | ||
auto libHdl = dlopen(path.c_str(), RTLD_NOW | RTLD_LOCAL); | ||
#endif | ||
if (libHdl == nullptr) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests for these exceptions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message is system dependent, we should improve our testing framework so that it allows fuzzy match error strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Can you open an issue on this? We should improve the testing framework for this.
6fabe51
to
886f584
Compare
This PR implements the extension framework and adds the
load extension [path]
statement to allow the user to load an extension in kuzu.Currently, extensions are not supported on windows platform due to a linking error.