common: add MPSC Queue #2612
Merged
common: add MPSC Queue #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2612 +/- ##
=======================================
Coverage 93.28% 93.28%
=======================================
Files 1037 1037
Lines 38870 38870
=======================================
Hits 36258 36258
Misses 2612 2612 ☔ View full report in Codecov by Sentry. |
Merged
ray6080
approved these changes
Dec 24, 2023
This queue is core to the new parallel hash index. It implements the design in this [blog][1], which is also used by Rust. The design is quite simple, and producers are wait-free. The main disadvantage is it is non-blocking, but adding blocking pop() support is tricky, and currently not needed. [1]: https://www.1024cores.net/home/lock-free-algorithms/queues/non-intrusive-mpsc-node-based-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This queue is core to the new parallel hash index. It implements the design in this blog, which is also used by Rust. The design is quite simple, and producers are wait-free. The main disadvantage is it is non-blocking, but adding blocking pop() support is tricky, and currently not needed.