Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added public headers explicitly to main/kuzu.h #2607

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

benjaminwinger
Copy link
Collaborator

Some things are missing from the single file header, probably as a result of reducing unnecessary includes and splitting up the headers.

This is related to an unimplemented part of #2136, that is, we should be compiling the API tests using just the single file header where possible to make sure that the public APIs are actually usable with the single file header included in the releases.

For now I've added everything I could think of (basically, most header files containing KUZU_API) to main/kuzu.h.

I omitted the exceptions, but maybe some or all of those should also be included so that users can catch specific exceptions (it looks like at the moment, Exception, InternalException, RuntimeException, BinderException and CatalogException are included in the single file header since they are used inline), however exceptions during queries are turned into an error message in the QueryResult, so for the most part I don't think that should be necessary.

Some things are missing from the single file header, probably as a result of reducing unnecessary includes
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b8a64d) 93.24% compared to head (1433f70) 93.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2607   +/-   ##
=======================================
  Coverage   93.24%   93.24%           
=======================================
  Files        1037     1037           
  Lines       38870    38870           
=======================================
  Hits        36246    36246           
  Misses       2624     2624           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminwinger benjaminwinger merged commit f9be254 into master Dec 22, 2023
14 checks passed
@benjaminwinger benjaminwinger deleted the missing-from-single-file-header branch December 22, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants