Added public headers explicitly to main/kuzu.h #2607
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some things are missing from the single file header, probably as a result of reducing unnecessary includes and splitting up the headers.
This is related to an unimplemented part of #2136, that is, we should be compiling the API tests using just the single file header where possible to make sure that the public APIs are actually usable with the single file header included in the releases.
For now I've added everything I could think of (basically, most header files containing
KUZU_API
) tomain/kuzu.h
.I omitted the exceptions, but maybe some or all of those should also be included so that users can catch specific exceptions (it looks like at the moment,
Exception
,InternalException
,RuntimeException
,BinderException
andCatalogException
are included in the single file header since they are used inline), however exceptions during queries are turned into an error message in theQueryResult
, so for the most part I don't think that should be necessary.