Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSR header: seprating offset and length #2601

Merged
merged 1 commit into from
Dec 22, 2023
Merged

CSR header: seprating offset and length #2601

merged 1 commit into from
Dec 22, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Dec 20, 2023

This is the precursor of the CSR update optimization. Only refactors existing code.

  1. Add length for each csr list. The offsets, together with lengths constitute CSRHeader. The change is mainly due to that we need to leave gaps between csr lists, and only keeping offsets is not enough to tell the length of each csr list.
  2. Separate CSR specific rel table data to a subclass CSRRelTableData of RelTableData.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (dd0efd3) 93.24% compared to head (c94a03a) 93.25%.

❗ Current head c94a03a differs from pull request most recent head 0ce0c87. Consider uploading reports for the commit 0ce0c87 to get more accurate results

Files Patch % Lines
src/storage/store/rel_table_data.cpp 98.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2601      +/-   ##
==========================================
+ Coverage   93.24%   93.25%   +0.01%     
==========================================
  Files        1037     1034       -3     
  Lines       38815    38723      -92     
==========================================
- Hits        36193    36113      -80     
+ Misses       2622     2610      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/include/processor/operator/persistent/copy_rel.h Outdated Show resolved Hide resolved
src/storage/store/rel_table_data.cpp Show resolved Hide resolved
src/storage/store/rel_table_data.cpp Show resolved Hide resolved
@ray6080 ray6080 merged commit 2b8a64d into master Dec 22, 2023
12 checks passed
@ray6080 ray6080 deleted the packed-csr branch December 22, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants