common: add copy constructor macros #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using std::unique_ptr all over the place to prevent copies, we can delete copy constructors. To enable this, this change adds three macros: EXPLICIT_COPY, NO_COPY, and NO_COPY_OR_MOVE. They should be added to any non-trivial class to define how copying and moving should be done. By default, move constructors and move assignment operators are enabled, unless disabled with NO_COPY_OR_MOVE. EXPLICIT_COPY adds a `.copy()` method, which can be used for explicit copying, making it clear when we are paying the price of a full copy. Future work could be done to ensure these macros are always added.
andyfengHKU
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using std::unique_ptr all over the place to prevent copies, we can delete copy constructors. To enable this, this change adds three macros: EXPLICIT_COPY, NO_COPY, and NO_COPY_OR_MOVE. They should be added to any non-trivial class to define how copying and moving should be done.
By default, move constructors and move assignment operators are enabled, unless disabled with NO_COPY_OR_MOVE. EXPLICIT_COPY adds a
.copy()method, which can be used for explicit copying, making it clear when we are paying the price of a full copy.Future work could be done to ensure these macros are always added.