Unify ku_dynamic_cast and ku_dynamic_ptr_cast with pointer-only check #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2593 +/- ##
==========================================
- Coverage 93.25% 93.25% -0.01%
==========================================
Files 1034 1034
Lines 38663 38662 -1
==========================================
- Hits 36057 36054 -3
- Misses 2606 2608 +2 ☔ View full report in Codecov by Sentry. |
benjaminwinger
force-pushed
the
cast-pointer
branch
from
6282c57
to
9253b39
Compare
benjaminwinger
force-pushed
the
cast-pointer
branch
from
9253b39
to
7a3c2a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.