Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2588 #2590

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Issue 2588 #2590

merged 1 commit into from
Dec 19, 2023

Conversation

andyfengHKU
Copy link
Contributor

Fix issue #2588

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (76af5c3) 93.24% compared to head (8143d08) 93.24%.

Files Patch % Lines
.../binder/query/reading_clause/bound_in_query_call.h 33.33% 4 Missing ⚠️
.../binder/query/reading_clause/bound_unwind_clause.h 50.00% 2 Missing ⚠️
...lude/binder/query/reading_clause/bound_load_from.h 0.00% 1 Missing ⚠️
src/planner/plan/plan_read.cpp 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2590      +/-   ##
==========================================
- Coverage   93.24%   93.24%   -0.01%     
==========================================
  Files        1030     1034       +4     
  Lines       38666    38701      +35     
==========================================
+ Hits        36053    36085      +32     
- Misses       2613     2616       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/binder/expression/expression_util.cpp Outdated Show resolved Hide resolved
src/optimizer/filter_push_down_optimizer.cpp Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU merged commit c0cce2b into master Dec 19, 2023
14 checks passed
@andyfengHKU andyfengHKU deleted the issue-2588 branch December 19, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants