-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement virtualFileSystem #2586
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acquamarin
force-pushed
the
filesystem
branch
from
December 16, 2023 05:21
06c0b44
to
0efea15
Compare
acquamarin
force-pushed
the
filesystem
branch
from
December 16, 2023 05:24
0efea15
to
727d0a8
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2586 +/- ##
==========================================
+ Coverage 93.15% 93.19% +0.03%
==========================================
Files 1027 1030 +3
Lines 38365 38664 +299
==========================================
+ Hits 35740 36032 +292
- Misses 2625 2632 +7 ☔ View full report in Codecov by Sentry. |
ray6080
approved these changes
Dec 18, 2023
acquamarin
force-pushed
the
filesystem
branch
from
December 19, 2023 02:34
727d0a8
to
54d3328
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first set of PRs to support HTTPFS/S3 filesystem extension.
This PR wraps all file operations under the FileSystem class.
Classes introduced: