Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable map type in rel table #2584

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Enable map type in rel table #2584

merged 1 commit into from
Jan 8, 2024

Conversation

benjaminwinger
Copy link
Collaborator

Already supported following the update to the rel table storage, but the exception checking that the previously unsupported types aren't used was still in place. Tests have been updated, though not exhaustively added for using the types in rel tables.

Fixes #2184

@ray6080
Copy link
Contributor

ray6080 commented Dec 14, 2023

Can you also add a test for COPY with MAP data type on rel tables? you can change one of MANY_MANY in tinysnb. and also test SERIAL with COPY actually.

@ray6080
Copy link
Contributor

ray6080 commented Dec 14, 2023

Also, as we discussed, we don't support serial as a non-pk property for now. So you might need to revert the check on serial on rel table, or you can solve this by supporting it all at once if you want.

@benjaminwinger benjaminwinger changed the title Enable remaining types in rel table Enable map type in rel table Dec 18, 2023
@benjaminwinger
Copy link
Collaborator Author

I clearly missed the part about serials not being supported as non-primary keys (reverted). But maps do seem to be working in rel tables when copying and inserting.

@benjaminwinger benjaminwinger force-pushed the rel-table-types branch 5 times, most recently from bd23d12 to 5f26b24 Compare December 18, 2023 19:04
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e4e0ea) 93.37% compared to head (fcaa1a5) 93.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2584   +/-   ##
=======================================
  Coverage   93.37%   93.38%           
=======================================
  Files        1063     1063           
  Lines       39403    39402    -1     
=======================================
  Hits        36794    36794           
+ Misses       2609     2608    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminwinger benjaminwinger merged commit 5cb2285 into master Jan 8, 2024
14 checks passed
@benjaminwinger benjaminwinger deleted the rel-table-types branch January 8, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants