Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue-2578 #2581

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Fix issue-2578 #2581

merged 1 commit into from
Dec 15, 2023

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Dec 14, 2023

Fix issue #2578

  • Fix a bug when paring predicate in subquery.
  • Fix a bug when using CASE in WHERE clause.
  • Fix a bug in unary boolean executor.
  • Fix a bug when using NULL key in index scan.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1a33e48) 93.15% compared to head (e6d7ca8) 93.21%.
Report is 2 commits behind head on master.

Files Patch % Lines
src/binder/bind/bind_graph_pattern.cpp 93.33% 1 Missing ⚠️
...clude/function/boolean/boolean_function_executor.h 85.71% 1 Missing ⚠️
src/planner/operator/logical_plan_util.cpp 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2581      +/-   ##
==========================================
+ Coverage   93.15%   93.21%   +0.05%     
==========================================
  Files        1027     1027              
  Lines       38365    38631     +266     
==========================================
+ Hits        35740    36008     +268     
+ Misses       2625     2623       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better put a PR description so it's easy to understand what is happening.

@andyfengHKU andyfengHKU merged commit 7b572bf into master Dec 15, 2023
14 checks passed
@andyfengHKU andyfengHKU deleted the issue-2578 branch December 15, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants