Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace reinterpret_cast and ku_dynamic_cast on pointers with ku_dynamic_ptr_cast #2561

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Dec 9, 2023

No description provided.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (15ac0e3) 93.15% compared to head (1a9eb64) 93.20%.

Files Patch % Lines
src/binder/bind/bind_graph_pattern.cpp 91.66% 1 Missing ⚠️
src/planner/operator/logical_plan_util.cpp 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2561      +/-   ##
==========================================
+ Coverage   93.15%   93.20%   +0.04%     
==========================================
  Files        1027     1027              
  Lines       38363    38614     +251     
==========================================
+ Hits        35737    35989     +252     
+ Misses       2626     2625       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 marked this pull request as ready for review December 13, 2023 18:10
@Riolku
Copy link
Contributor

Riolku commented Dec 14, 2023

More accurately, this is a PR to exchange reinterpret_cast for ku_dynamic_ptr_cast, not one to add it :)

@ray6080
Copy link
Contributor Author

ray6080 commented Dec 14, 2023

More accurately, this is a PR to exchange reinterpret_cast for ku_dynamic_ptr_cast, not one to add it :)

True 😄 also for some ku_dynamic_cast, which are reserved mostly for casting between references, which can be addressed later if necessary

@ray6080 ray6080 changed the title Add ku_dynamic_ptr_cast Replace reinterpret_cast and ku_dynamic_cast on pointers with ku_dynamic_ptr_cast Dec 14, 2023
@ray6080 ray6080 merged commit 3f6e1d4 into master Dec 14, 2023
14 checks passed
@ray6080 ray6080 deleted the dynamic_ptr_cast branch December 14, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants