Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some cases of unnecessary std::move on return #2555

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

benjaminwinger
Copy link
Collaborator

These are all doing moves on temporary values wrapped in unique_ptr and the move is unnecessary and produces a compiler warning.

One's not actually when returning, but is a move on an in-place constructed value where it's already an rvalue.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9147b85) 92.91% compared to head (0006eb7) 92.90%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2555      +/-   ##
==========================================
- Coverage   92.91%   92.90%   -0.02%     
==========================================
  Files        1025     1025              
  Lines       38401    38401              
==========================================
- Hits        35679    35675       -4     
- Misses       2722     2726       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminwinger benjaminwinger merged commit 7c44c87 into master Dec 8, 2023
14 checks passed
@benjaminwinger benjaminwinger deleted the return-move branch December 8, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants