Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: disable scripts #2550

Merged
merged 1 commit into from
Dec 5, 2023
Merged

rust: disable scripts #2550

merged 1 commit into from
Dec 5, 2023

Conversation

Riolku
Copy link
Collaborator

@Riolku Riolku commented Dec 5, 2023

Rust doesn't need the single file header. In the interest of keeping the
crate size small, I've simply added a flag that disables generation of
the single file header. The single file header still builds by default.

Additionally, Rust shouldn't use the automatic grammar generation. I've
also disabled that in the crate build.

@Riolku
Copy link
Collaborator Author

Riolku commented Dec 5, 2023

@Riolku Riolku changed the title rust: disable single file header rust: disable scripts Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a00a72a) 92.85% compared to head (9adba6c) 92.86%.
Report is 3 commits behind head on master.

❗ Current head 9adba6c differs from pull request most recent head f1dd6b6. Consider uploading reports for the commit f1dd6b6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2550   +/-   ##
=======================================
  Coverage   92.85%   92.86%           
=======================================
  Files        1025     1025           
  Lines       38324    38324           
=======================================
+ Hits        35586    35589    +3     
+ Misses       2738     2735    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Riolku
Copy link
Collaborator Author

Riolku commented Dec 5, 2023

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated
option(BUILD_BENCHMARK "Build benchmarks." FALSE)
option(BUILD_EXAMPLES "Build examples." FALSE)
option(BUILD_JAVA "Build Java API." FALSE)
option(BUILD_NODEJS "Build NodeJS API." FALSE)
option(BUILD_PYTHON "Build Python API." FALSE)
option(BUILD_SHELL "Build Interactive Shell" TRUE)
option(BUILD_SINGLE_FILE_HEADER "Build single file header." TRUE)
Copy link
Collaborator

@benjaminwinger benjaminwinger Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention that this requires python in the description?

And while it's not entirely related, the Building from Source docs still say that python headers are needed, while that should only be necessary if building the python API and could be moved to an API-specific dependency.
Strictly speaking this change will also mean that python itself is entirely optional, but maybe it's easier to still say that python is required, since usually people will want the single file header, than it would be to explain the conditions where it is required.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: python dev headers, the docs just need to be redeployed (kuzudb/kuzu-docs#48 was merged).

Rust doesn't need the single file header. In the interest of keeping the
crate size small, I've simply added a flag that disables generation of
the single file header. The single file header still builds by default.

Additionally, Rust shouldn't use the automatic grammar generation. I've
also disabled that in the crate build.
@Riolku Riolku merged commit 1e11e06 into master Dec 5, 2023
9 of 10 checks passed
@Riolku Riolku deleted the fix-rust-deployment branch December 5, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants