cmake: build single-file-header with cmake #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riolku
force-pushed
the
cmake-install-include
branch
2 times, most recently
from
bdd2cf5
to
9c89868
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2526 +/- ##
=======================================
Coverage 91.57% 91.57%
=======================================
Files 1028 1029 +1
Lines 38036 38042 +6
=======================================
+ Hits 34832 34838 +6
Misses 3204 3204 ☔ View full report in Codecov by Sentry. |
Riolku
force-pushed
the
cmake-install-include
branch
8 times, most recently
from
6e595b7
to
9fdddc0
Compare
Riolku
force-pushed
the
cmake-install-include
branch
2 times, most recently
from
c82383a
to
d1b1d11
Compare
Riolku
force-pushed
the
cmake-install-include
branch
3 times, most recently
from
1adc0f2
to
a921fe7
Compare
This also allows us to install headers with cmake, and completely remove our `build.py` script. Since the C++ example now builds with the single file header, `make tidy` doesn't work properly. Instead of fixing it, I have removed examples from the tidy checking. I'm not convinced it really makes sense.
Riolku
force-pushed
the
cmake-install-include
branch
from
a921fe7
to
4d82377
Compare
3 tasks
|
LGTM. Let's update the docs here and state that we need Python 3.9+ to build. |
mewim
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also allows us to install headers with cmake, and completely remove our
build.pyscript.Since the C++ example now builds with the single file header,
make tidydoesn't work properly. Instead of fixing it, I have removed examples from the tidy checking. I'm not convinced it really makes sense.