Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finish adding timestamp_ns/ms/sec/tz datatypes #2506

Merged
merged 1 commit into from
Dec 2, 2023
Merged

finish adding timestamp_ns/ms/sec/tz datatypes #2506

merged 1 commit into from
Dec 2, 2023

Conversation

AEsir777
Copy link
Contributor

@AEsir777 AEsir777 commented Nov 28, 2023 •
edited
Loading

Added support for timestamp_ns/_ms/_sec/_tz datatypes

  • for node.js, c, following duckdb manner, so there is no timezone for timestamp_tz
  • for java, Instant does not support timezone
  • python supports timezone for arrow and python api. Numpy/pandas current only support datetime_us to have time zone information
  • Rust already contains UTC
  • Renabled some test_to_arrow test

@AEsir777 AEsir777 force-pushed the timestamp branch 7 times, most recently from 8577746 to 79179c5 Compare November 28, 2023 21:01
@AEsir777 AEsir777 marked this pull request as ready for review November 28, 2023 21:10
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (734c89b) 91.56% compared to head (6155fd7) 92.87%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2506      +/-   ##
==========================================
+ Coverage   91.56%   92.87%   +1.30%     
==========================================
  Files        1029     1025       -4     
  Lines       38059    38342     +283     
==========================================
+ Hits        34849    35609     +760     
+ Misses       3210     2733     -477

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

acquamarin
acquamarin approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@acquamarin acquamarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may also have to add the timestamp support to scanPandas

src/c_api/prepared_statement.cpp Show resolved Hide resolved
src/common/types/timestamp_t.cpp Outdated Show resolved Hide resolved
@AEsir777 AEsir777 force-pushed the timestamp branch 2 times, most recently from 46a5943 to 91ce18d Compare November 29, 2023 02:23
@AEsir777 AEsir777 requested a review from mewim November 29, 2023 02:27
@AEsir777 AEsir777 force-pushed the timestamp branch 4 times, most recently from bdd48f9 to cec0ed3 Compare December 1, 2023 17:05
mewim
mewim approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@mewim mewim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes on Node.js, Python, C, and Java APIs. LGTM

@AEsir777 AEsir777 merged commit 7e3890b into master Dec 2, 2023
14 checks passed
@AEsir777 AEsir777 deleted the timestamp branch December 2, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mewim mewim mewim approved these changes

@acquamarin acquamarin acquamarin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AEsir777 @mewim @acquamarin