Hide catalog content #2502
Merged
Hide catalog content #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfengHKU
force-pushed
the
hide-catalog-content
branch
2 times, most recently
from
40c23b8
to
575761e
Compare
acquamarin
approved these changes
Nov 27, 2023
andyfengHKU
force-pushed
the
hide-catalog-content
branch
2 times, most recently
from
158e5df
to
a5322b7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2502 +/- ##
==========================================
+ Coverage 91.56% 91.57% +0.01%
==========================================
Files 1028 1028
Lines 37992 38020 +28
==========================================
+ Hits 34787 34817 +30
+ Misses 3205 3203 -2 ☔ View full report in Codecov by Sentry. |
andyfengHKU
force-pushed
the
hide-catalog-content
branch
from
a5322b7
to
eae3ba2
Compare
andyfengHKU
force-pushed
the
hide-catalog-content
branch
from
eae3ba2
to
af680ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hides as many interfaces as possible for CatalogContent. All access to catalog information should directly go through catalog with a transaction pointer. See changes in
catalog.h&catalog_content.h. This PR also takes us one step closer to support manual transaction over DDL.Note that since we were not passing transaction pointer properly for DDL code path, I have to use
DUMMY_READ_TRANSACTIONin many places, specificallyPlanner & WAL.Also I'm commenting out DDL transaction test. We should no longer maintain end2end test through cpp code.