tidy: check for non-virtual destructors #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check implements [this guideline][1]. A base class' destructor should either be public and virtual, meaning that the object can be destroyed through a pointer to the base class (e.g. a unique_ptr<Base>), or protected and non-virtual, meaning that the destructor cannot be invoked on a pointer to the base class. Private destructors would mean that children can't invoke the parent destructor, which is undesirable. [1]: http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rc-dtor-virtual
acquamarin
approved these changes
Nov 24, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2498 +/- ##
==========================================
- Coverage 91.53% 91.51% -0.03%
==========================================
Files 1026 1026
Lines 37906 37909 +3
==========================================
- Hits 34697 34692 -5
- Misses 3209 3217 +8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check implements this guideline. A base class' destructor should either be public and virtual, meaning that the object can be destroyed through a pointer to the base class (e.g. a unique_ptr), or protected and non-virtual, meaning that the destructor cannot be invoked on a pointer to the base class. Private destructors would mean that children can't invoke the parent destructor, which is undesirable.