Pytest cleanup #2493
Merged
Pytest cleanup #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2493 +/- ##
==========================================
+ Coverage 91.52% 91.53% +0.01%
==========================================
Files 1026 1026
Lines 37906 37906
==========================================
+ Hits 34695 34699 +4
+ Misses 3211 3207 -4 ☔ View full report in Codecov by Sentry. |
benjaminwinger
force-pushed
the
pytest-cleanup
branch
from
cb9b8d9
to
27137c1
Compare
Riolku
approved these changes
Nov 23, 2023
benjaminwinger
force-pushed
the
pytest-cleanup
branch
from
27137c1
to
2b3a23e
Compare
benjaminwinger
force-pushed
the
pytest-cleanup
branch
from
2b3a23e
to
1260d50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes test_main, which is unnecessary and when tests fail the output indicates test_main.py as the file instead of the actual file containing the test.
I've also removed the relative paths to allow pytest to be run from any directory, and removed the
sys.pathmodifications in-code in favour of using thePYTHONPATHenvironment variable (set in the makefile).