tidy: enforce adding override #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riolku
force-pushed
the
tidy-override
branch
from
a570cec
to
8e6a1b1
Compare
acquamarin
approved these changes
Nov 23, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2489 +/- ##
=======================================
Coverage 91.53% 91.53%
=======================================
Files 1026 1026
Lines 37904 37906 +2
=======================================
+ Hits 34694 34696 +2
Misses 3210 3210 ☔ View full report in Codecov by Sentry. |
ray6080
approved these changes
Nov 23, 2023
|
Ah nevermind, clang tidy doesnt check header files that have this issue... I really thought it was supposed to... |
Riolku
force-pushed
the
tidy-override
branch
from
8e6a1b1
to
b31cbed
Compare
|
Updated commit message: |
Riolku
force-pushed
the
tidy-override
branch
from
b31cbed
to
a29584d
Compare
It turns out that `HeaderFilterRegex` uses a Posix Extended Regular Expression, which doesn't support lookbacks. The easiest solution is to just fix the _one_ error in linenoise.h. Note that the `run-clang-tidy` regex _does_ support lookbacks, since it's a normal Python regex.
Riolku
force-pushed
the
tidy-override
branch
from
a29584d
to
c66191d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out only one place in our codebase was missing this. Good job us!