finish add tryMultiply to check overflow #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AEsir777
force-pushed
the
try-multiply
branch
from
c0a1315
to
8a706b3
Compare
AEsir777
force-pushed
the
try-multiply
branch
from
8a706b3
to
265d6bc
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2484 +/- ##
=======================================
Coverage 91.52% 91.53%
=======================================
Files 1024 1026 +2
Lines 37855 37904 +49
=======================================
+ Hits 34648 34694 +46
- Misses 3207 3210 +3 ☔ View full report in Codecov by Sentry. |
AEsir777
force-pushed
the
try-multiply
branch
2 times, most recently
from
d4236e9
to
2b2fd46
Compare
acquamarin
approved these changes
Nov 22, 2023
AEsir777
force-pushed
the
try-multiply
branch
2 times, most recently
from
f509e54
to
570740e
Compare
Remove CompressionAlg::getValue
AEsir777
force-pushed
the
try-multiply
branch
from
570740e
to
e5558c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now multiply will check if the result is within range of the operand types. If not, overflow exception will be thrown.