Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #2474: parse dataType map() with 0 or no arg aborts #2476

Merged
merged 1 commit into from
Nov 20, 2023
Merged

fix #2474: parse dataType map() with 0 or no arg aborts #2476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/string_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ std::vector<std::string> StringUtils::splitComma(const std::string& input) {
currentPos++;
}
result.push_back(input.substr(0, currentPos));
result.push_back(input.substr(currentPos + 1));
result.push_back(input.substr(currentPos == input.length() ? input.length() : currentPos + 1));
return result;
}

Expand Down
37 changes: 37 additions & 0 deletions test/test_files/tinysnb/cast/cast_error.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,3 +798,40 @@ Conversion exception: Unsupported casting function from INT16[2] to FLOAT[1].
---- error
Runtime exception: Unsupported FIXED_LIST type: Function::getFixedListChildCastFunc

-LOG InvalidNestedCast
-STATEMENT RETURN cast({a: {b: {c: [[1, 3, 4]], d: "str"}}, e: [1, 9, NULL]}, "STRUCT(a STRUCT(b STRUCT(c INT64[2][], d STRING)), e INT128[3])");
---- error
Conversion exception: Unsupported casting VAR_LIST with incorrect list entry to FIXED_LIST. Expected: 2, Actual: 3.
-STATEMENT RETURN cast({a: {b: {c: [[1, 3, 4]], d: "str"}}, e: [1, 9, NULL]}, "STRUCT(a STRUCT(b STRUCT(c INT64[3][], d STRING)), e INT128[3])");
---- error
Conversion exception: Cast failed. NULL is not allowed for FIXED_LIST.
-STATEMENT RETURN cast(cast("{a: {b: {c: [[1, 3, 4]], d: {18=[3, 2]}}}, e: [1, 9, 3]}", "STRUCT(a STRUCT(b STRUCT(c INT64[3][], d MAP(INT32,INT32[]))), e FLOAT[3])"), "STRUCT(a STRUCT(b STRUCT(c INT64[3][], d MAP(INT32,INT32[5]))), e INT32[3])");
---- error
Conversion exception: Unsupported casting VAR_LIST with incorrect list entry to FIXED_LIST. Expected: 5, Actual: 2.

-LOG InvalidNameCast
-STATEMENT RETURN cast("nop", "STRUCT()");
---- error
Cannot parse dataTypeID:
-STATEMENT RETURN cast("nop", "STRUCT(a=fds)");
---- error
Cannot parse dataTypeID: A=FDS
-STATEMENT RETURN cast("nop", "STRUCT(a: )");
---- error
Cannot parse dataTypeID:
-STATEMENT RETURN cast("nop", "MAP()");
---- error
Cannot parse dataTypeID:
-STATEMENT RETURN cast("nop", "MAP(");
---- error
Cannot parse map type: MAP(
-STATEMENT RETURN cast("nop", "UNION(a:STRING)");
---- error
Cannot parse dataTypeID: A:STRING
-STATEMENT RETURN cast("nop", "MAP(int)");
---- error
Cannot parse dataTypeID:
-STATEMENT RETURN cast("nop", "STRUCT(a: INT, b MAP(INT, STRING, INT))");
---- error
Cannot parse dataTypeID: STRING, INT