Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DB version call #2466

Merged
merged 6 commits into from
Nov 20, 2023
Merged

Fix DB version call #2466

merged 6 commits into from
Nov 20, 2023

Conversation

mewim
Copy link
Collaborator

@mewim mewim commented Nov 20, 2023

No description provided.

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a5b11d) 91.46% compared to head (46ad0f6) 91.46%.
Report is 3 commits behind head on master.

❗ Current head 46ad0f6 differs from pull request most recent head f32070b. Consider uploading reports for the commit f32070b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2466      +/-   ##
==========================================
- Coverage   91.46%   91.46%   -0.01%     
==========================================
  Files        1025     1025              
  Lines       37627    37627              
==========================================
- Hits        34417    34416       -1     
- Misses       3210     3211       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mewim and others added 4 commits November 20, 2023 17:39
Since it's set using a compile definition, we want to avoid that definition being required to include the header
@mewim mewim merged commit 072c256 into master Nov 20, 2023
10 checks passed
@mewim mewim deleted the fix-db-version branch November 20, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants