cmake: strip main binaries #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riolku
force-pushed
the
strip-main-binaries
branch
from
7c3a9c4
to
5ef546a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2455 +/- ##
==========================================
- Coverage 91.48% 91.48% -0.01%
==========================================
Files 1025 1025
Lines 37646 37646
==========================================
- Hits 34440 34439 -1
- Misses 3206 3207 +1 ☔ View full report in Codecov by Sentry. |
Riolku
force-pushed
the
strip-main-binaries
branch
3 times, most recently
from
3749914
to
f178aac
Compare
Riolku
force-pushed
the
strip-main-binaries
branch
from
b618fe1
to
ae813f3
Compare
Instead of the very complex #2443, this PR is a comparably simple change that strips `libkuzu.so`, `kuzu_shell` and `libkuzu.a`.
Riolku
force-pushed
the
strip-main-binaries
branch
from
ae813f3
to
3ab8b84
Compare
mewim
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the very complex #2443, this PR is a comparably simple change that strips
libkuzu.so,kuzu_shellandlibkuzu.a.