Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UDF checkpoint logic #2451

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Fix UDF checkpoint logic #2451

merged 1 commit into from
Nov 18, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Nov 18, 2023

When initializing the write version of the catalogContent, we simply create a new catalogContent and regenerate the built-in funcionts. However, this discards all UDFs since all functions are not copied.
This PR correctly copies all functions when initializing the write version of the catalogContent

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (295d2de) 91.38% compared to head (57784b1) 91.40%.

Files Patch % Lines
src/function/built_in_functions.cpp 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2451      +/-   ##
==========================================
+ Coverage   91.38%   91.40%   +0.01%     
==========================================
  Files        1023     1023              
  Lines       37235    37246      +11     
==========================================
+ Hits        34028    34044      +16     
+ Misses       3207     3202       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better give a more descriptive title or add a brief description, as the title doesn't seem to cover the problem of functions with transaction.

@acquamarin acquamarin changed the title Fix add-function Fix UDF checkpoint logic Nov 18, 2023
@acquamarin acquamarin merged commit 25e6778 into master Nov 18, 2023
12 checks passed
@acquamarin acquamarin deleted the function-registeration branch November 18, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants