Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Column write interface #2447

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Nov 18, 2023

Rework the Column write interface to take in both nodeGroupIdx and offsetInChunk, instead of the global nodeOffset.
This is need by rel table writes, which doesn't always calculate nodeGroupIdx in the same way as node table columns.

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (32c358b) 91.38% compared to head (bd118b9) 91.38%.

Files Patch % Lines
src/storage/store/column.cpp 88.23% 8 Missing ⚠️
src/storage/store/struct_column.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2447   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files        1023     1023           
  Lines       37235    37235           
=======================================
  Hits        34028    34028           
  Misses       3207     3207           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit 8f6f2ed into master Nov 18, 2023
12 checks passed
@ray6080 ray6080 deleted the rework-column-write-interface branch November 18, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants