Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting the set of numValues for column chunk in CopyRel and fix writing null struct entry #2445

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Nov 17, 2023

  1. numValues of the csrOffsetColumnChunk / adjColumnChunk should be set according to numNodes from source node table that falls into this node group.
  2. when a struct entry is null, writing it would trigger unnecessary out-of-place commits for children fields, due to that the input Vector doesn't guarantee its child vector are all set to null. fix this by skipping writing values of children fields, instead setting them all to null.

@ray6080 ray6080 force-pushed the copy-rel-correction branch 2 times, most recently from 5e3ad79 to 3dfb056 Compare November 17, 2023 22:49
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (7ef3d5c) 90.86% compared to head (64a6c4b) 90.85%.
Report is 2 commits behind head on master.

Files Patch % Lines
src/storage/store/struct_column.cpp 0.00% 8 Missing ⚠️
src/storage/store/node_group.cpp 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2445      +/-   ##
==========================================
- Coverage   90.86%   90.85%   -0.01%     
==========================================
  Files        1023     1023              
  Lines       37044    37063      +19     
==========================================
+ Hits        33659    33674      +15     
- Misses       3385     3389       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit 8627450 into master Nov 17, 2023
12 checks passed
@ray6080 ray6080 deleted the copy-rel-correction branch November 17, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants