Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update struct fields in-place or out of place as necessary #2442

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

benjaminwinger
Copy link
Collaborator

Fixes #2437.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f7779ac) 90.70% compared to head (a53cd01) 90.86%.
Report is 3 commits behind head on master.

Files Patch % Lines
src/storage/local_storage/local_table.cpp 85.71% 1 Missing ⚠️
src/storage/store/struct_column.cpp 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2442      +/-   ##
==========================================
+ Coverage   90.70%   90.86%   +0.16%     
==========================================
  Files        1023     1023              
  Lines       37014    37044      +30     
==========================================
+ Hits        33572    33659      +87     
+ Misses       3442     3385      -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminwinger benjaminwinger merged commit 7ef3d5c into master Nov 17, 2023
12 checks passed
@benjaminwinger benjaminwinger deleted the struct-field-out-of-place-fix branch November 17, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structs containing strings and integers aren't updated out of place
2 participants