Always write a whole page at a time when writing compressed data #2438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix from #2408 which ended up breaking windows CI in #2304.
If data is compressed to 0 bytes, it would end up writing nothing, and if the data is at the end of the file the next time the file is opened it will read the number of pages as one less, triggering exceptions when attempting to read the last page.
Ideally we shouldn't be reading at all when data is compressed to nothing, but that can be addressed later.