Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy-to-csv header option #2436

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Add copy-to-csv header option #2436

merged 1 commit into from
Nov 17, 2023

Conversation

acquamarin
Copy link
Collaborator

This PR adds an option to allow user to specify whether or not to write a header for the CSV file.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (093e627) 90.54% compared to head (a373cae) 90.56%.
Report is 3 commits behind head on master.

Files Patch % Lines
...nclude/processor/operator/persistent/copy_to_csv.h 60.00% 2 Missing ⚠️
...de/processor/operator/persistent/copy_to_parquet.h 50.00% 2 Missing ⚠️
src/processor/operator/persistent/copy_to_csv.cpp 94.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2436      +/-   ##
==========================================
+ Coverage   90.54%   90.56%   +0.01%     
==========================================
  Files        1020     1020              
  Lines       36515    36533      +18     
==========================================
+ Hits        33064    33085      +21     
+ Misses       3451     3448       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acquamarin acquamarin merged commit ef27e49 into master Nov 17, 2023
12 checks passed
@acquamarin acquamarin deleted the copy-to-header branch November 17, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants