Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count subquery #2429

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Count subquery #2429

merged 1 commit into from
Nov 17, 2023

Conversation

andyfengHKU
Copy link
Contributor

Add count subquery. This should also fix issue #2182

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (cd61648) 90.71% compared to head (6ee73d2) 90.68%.

Files Patch % Lines
src/planner/plan/plan_subquery.cpp 81.48% 5 Missing ⚠️
...c/processor/operator/hash_join/hash_join_probe.cpp 84.61% 2 Missing ⚠️
...inder/bind_expression/bind_subquery_expression.cpp 95.45% 1 Missing ⚠️
src/parser/expression/parsed_expression.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2429      +/-   ##
==========================================
- Coverage   90.71%   90.68%   -0.03%     
==========================================
  Files        1023     1023              
  Lines       36948    37014      +66     
==========================================
+ Hits        33517    33567      +50     
- Misses       3431     3447      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU merged commit f7779ac into master Nov 17, 2023
11 of 12 checks passed
@andyfengHKU andyfengHKU deleted the count-subquery branch November 17, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants