Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cmake project version number in code #2428

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

benjaminwinger
Copy link
Collaborator

To reduce the number of places we need to update the version number, I've set up cmake to pass it as a compiler definition so it can be re-used in the C++ code.

@benjaminwinger benjaminwinger mentioned this pull request Nov 16, 2023
1 task
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a616abf) 90.54% compared to head (e895007) 90.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2428   +/-   ##
=======================================
  Coverage   90.54%   90.54%           
=======================================
  Files        1020     1020           
  Lines       36515    36515           
=======================================
  Hits        33063    33063           
  Misses       3452     3452           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminwinger benjaminwinger merged commit 093e627 into master Nov 16, 2023
12 checks passed
@benjaminwinger benjaminwinger deleted the cmake-version branch November 16, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants