Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rel delete and create #2427

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Fix rel delete and create #2427

merged 1 commit into from
Nov 18, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Nov 16, 2023

No description provided.

@ray6080 ray6080 force-pushed the fix-rel-updates branch 2 times, most recently from 53bc76b to 6237df3 Compare November 16, 2023 19:09
@ray6080 ray6080 force-pushed the fix-rel-create-delete branch 2 times, most recently from 43f40aa to 815e0a1 Compare November 16, 2023 20:15
Base automatically changed from fix-rel-updates to master November 17, 2023 01:41
@ray6080 ray6080 force-pushed the fix-rel-create-delete branch 2 times, most recently from 130bb38 to c29f0fd Compare November 17, 2023 03:57
@ray6080 ray6080 marked this pull request as ready for review November 17, 2023 03:57
@ray6080 ray6080 mentioned this pull request Nov 17, 2023
Open
@codecov Codecov
Copy link

codecov bot commented Nov 17, 2023 •
edited
Loading

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (8627450) 90.86% compared to head (21ecefd) 91.38%.

Files Patch % Lines
src/storage/store/rel_table_data.cpp 94.25% 5 Missing ⚠️
...clude/processor/operator/persistent/set_executor.h 66.66% 2 Missing ⚠️
src/storage/store/column.cpp 84.61% 2 Missing ⚠️
src/storage/local_storage/local_rel_table.cpp 92.30% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2427      +/-   ##
==========================================
+ Coverage   90.86%   91.38%   +0.51%     
==========================================
  Files        1023     1023              
  Lines       37063    37190     +127     
==========================================
+ Hits        33679    33986     +307     
+ Misses       3384     3204     -180

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 force-pushed the fix-rel-create-delete branch 2 times, most recently from 09bea9b to cb115ba Compare November 17, 2023 04:27
acquamarin
acquamarin approved these changes Nov 17, 2023
View reviewed changes
src/include/processor/operator/persistent/delete_executor.h Outdated Show resolved Hide resolved
src/storage/store/column_chunk.cpp Show resolved Hide resolved
src/storage/store/rel_table_data.cpp Show resolved Hide resolved
src/storage/store/rel_table_data.cpp Show resolved Hide resolved
@ray6080
t# This is a combination of 2 commits.
21ecefd 
fix rel delete and create
@ray6080 ray6080 merged commit da8dd60 into master Nov 18, 2023
12 checks passed
@ray6080 ray6080 deleted the fix-rel-create-delete branch November 18, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acquamarin acquamarin acquamarin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ray6080 @acquamarin