Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rel updates #2425

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Fix rel updates #2425

merged 1 commit into from
Nov 17, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Nov 16, 2023

Fix SET on rel tables. Also introduce the rel local storage. This is gonna break our test coverage as code path for insert/delete in local storage are not covered yet, which will be covered in the following PR.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 86 lines in your changes are missing coverage. Please review.

Comparison is base (bb159fe) 90.44% compared to head (fb0bfcf) 90.70%.

Files Patch % Lines
src/storage/local_storage/local_rel_table.cpp 40.00% 69 Missing ⚠️
...rc/include/storage/local_storage/local_rel_table.h 76.47% 4 Missing ⚠️
src/storage/local_storage/local_node_table.cpp 96.84% 3 Missing ⚠️
src/storage/store/column.cpp 82.35% 3 Missing ⚠️
...c/include/storage/local_storage/local_node_table.h 81.81% 2 Missing ⚠️
src/processor/operator/persistent/merge.cpp 0.00% 2 Missing ⚠️
src/include/storage/local_storage/local_table.h 87.50% 1 Missing ⚠️
src/include/storage/store/string_column.h 0.00% 1 Missing ⚠️
src/storage/local_storage/local_table.cpp 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2425      +/-   ##
==========================================
+ Coverage   90.44%   90.70%   +0.26%     
==========================================
  Files        1020     1024       +4     
  Lines       36641    36868     +227     
==========================================
+ Hits        33139    33441     +302     
+ Misses       3502     3427      -75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/include/common/enums/rel_direction.h Outdated Show resolved Hide resolved
src/storage/local_storage/local_table.cpp Show resolved Hide resolved
src/storage/local_storage/local_table.cpp Outdated Show resolved Hide resolved
src/processor/map/map_set.cpp Show resolved Hide resolved
@ray6080 ray6080 force-pushed the fix-rel-updates branch 2 times, most recently from 53bc76b to 6237df3 Compare November 16, 2023 19:09
@ray6080 ray6080 merged commit 33bc524 into master Nov 17, 2023
10 of 12 checks passed
@ray6080 ray6080 deleted the fix-rel-updates branch November 17, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants