Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abstraction of LocalTableData to LocalStorage #2420

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Nov 15, 2023

This is an abstraction that will be used for rel tables, as each rel table will require both fwd and bwd data. The idea is same as what we did with Table and TableData.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (80a8b59) 91.21% compared to head (b7e820f) 91.16%.
Report is 2 commits behind head on master.

❗ Current head b7e820f differs from pull request most recent head 3cde464. Consider uploading reports for the commit 3cde464 to get more accurate results

Files Patch % Lines
src/storage/store/rel_table.cpp 0.00% 2 Missing ⚠️
src/storage/local_storage/local_table.cpp 94.44% 1 Missing ⚠️
src/storage/store/rel_table_data.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2420      +/-   ##
==========================================
- Coverage   91.21%   91.16%   -0.05%     
==========================================
  Files        1020     1020              
  Lines       36344    36327      -17     
==========================================
- Hits        33152    33119      -33     
- Misses       3192     3208      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit 8ad6ce0 into master Nov 16, 2023
10 checks passed
@ray6080 ray6080 deleted the rework-local-storage branch November 16, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants