Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more types to arrow export #2419

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Add more types to arrow export #2419

merged 1 commit into from
Nov 15, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Nov 15, 2023

This PR adds the following types to arrow export:
INT128, INT8, UINT64, UINT32, UINT16, UINT8, FIXED_LIST, STRUCT

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 140 lines in your changes are missing coverage. Please review.

Comparison is base (251484d) 91.20% compared to head (1c5ef15) 90.47%.
Report is 4 commits behind head on master.

Files Patch % Lines
src/common/arrow/arrow_row_batch.cpp 3.92% 98 Missing ⚠️
src/common/arrow/arrow_converter.cpp 0.00% 35 Missing ⚠️
src/main/query_result.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2419      +/-   ##
==========================================
- Coverage   91.20%   90.47%   -0.73%     
==========================================
  Files        1020     1020              
  Lines       36343    36481     +138     
==========================================
- Hits        33146    33008     -138     
- Misses       3197     3473     +276     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acquamarin acquamarin merged commit 507e245 into master Nov 15, 2023
11 of 12 checks passed
@acquamarin acquamarin deleted the arrow-fix branch November 15, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants