Rework Column and ColumnChunk's dataType field to std::unique_ptr #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acquamarin
approved these changes
Nov 15, 2023
| val.internalIDVal = val_; | ||
| } | ||
|
|
||
| Value::Value(const char* val_) : isNull_{false} { | ||
| dataType = std::make_unique<LogicalType>(LogicalTypeID::STRING); | ||
| dataType = LogicalType::STRING(); | ||
| strVal = std::string(val_); | ||
| } | ||
|
|
||
| Value::Value(uint8_t* val_) : isNull_{false} { |
There was a problem hiding this comment.
We should also create interfaces to create nested datatype(e.g. varlist, struct)
There was a problem hiding this comment.
for nested types, I'm not sure. It may not be able to simplify much.
ray6080
force-pushed
the
column-logical-type
branch
from
b533141
to
b72ec8a
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2418 +/- ##
==========================================
- Coverage 91.20% 91.20% -0.01%
==========================================
Files 1020 1020
Lines 36343 36344 +1
==========================================
Hits 33146 33146
- Misses 3197 3198 +1 ☔ View full report in Codecov by Sentry. |
ray6080
force-pushed
the
column-logical-type
branch
from
b72ec8a
to
f7c9f7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the title. This simplifies the implicit copy and life cycle problems related to LogicalType. We should change the one inside ValueVector too.
Also, added some syntax sugars inside
LogicalType, such asLogicalType::BOOL(),LogicalType::INT64()to avoidstd::make_unique(...).Another minor change is to make
csrOffsetColumnandadjColumnto reuseRWPropertyStats::empty()for constructing the rw property stats inside their constructors.