cleanup: replace NotImplementedException #2401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riolku
force-pushed
the
not-implemented-unreachable
branch
2 times, most recently
from
d9f53e0
to
b7abf7d
Compare
KU_UNREACHABLE should be used in almost all cases where we have NotImplementedException.
Riolku
force-pushed
the
not-implemented-unreachable
branch
from
b7abf7d
to
073fdc4
Compare
|
Also cleaned up an instance where invalid |
acquamarin
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KU_UNREACHABLE should be used in almost all cases where we have NotImplementedException.